Try to fix time difference issues of timeseries2csv #19
Conversation
stephanritscher
force-pushed
the
main
branch
from
8abdf8f to
8baa4f6
Compare
stephanritscher
force-pushed
the
main
branch
from
1fc6e38 to
7720dae
Compare
stephanritscher
force-pushed
the
main
branch
from
dd514b8 to
eb394cb
Compare
stephanritscher
force-pushed
the
main
branch
from
eb394cb to
723901d
Compare
- `pytz`: the module is deprecated and shouldn't be used any longer - `datetime.utcfromtimestamp()` is deprecated since Python 3.12, the alternative works in 3.11 (our current lower bound)
|
Hi, sorry for being absent from the project for so long. I really like how robust you've mad it. I've added a commit to move away from some deprecated modules and functions; some quick checks on machines using UTC and CET show no difference with/without the patch, but I'm not using the script regularly so it would be cool if you could check if it does not break anything for real use-cases. |
|
So, I've unfortunately rushed ahead with changes to the project structure itself and only afterwards realised your PR touches some parts that are no longer there. The rebase isn't too complicated, but it would require a force-push, and I'm not comfortable rewriting your project's history (I doubt it'd let me do it in the first place). So, I'll go ahead and create a merge of a local rebase of this PR instead. If things don't work, my added commit is to blame 😅 One thing I haven't figured out is how to port setup.py's scripts array to pyproject.toml, so for the time being I'll just drop that particular commit. |
|
Thanks. I hope to find time to switch to your new version and give you feedback anytime soon. |
2 participants
As I argued in #7, I think RCT power devices handle timezone information incorrectly when converting between readable dates and timestamps. This PR tries to address this problem.